Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List materialized views #154

Open
5 of 12 tasks
aricart opened this issue Sep 19, 2022 · 5 comments
Open
5 of 12 tasks

List materialized views #154

aricart opened this issue Sep 19, 2022 · 5 comments
Assignees
Labels
client Client related work enhancement New feature or request

Comments

@aricart
Copy link
Member

aricart commented Sep 19, 2022

Overview

Go client started listing materialized views like KVs directly. This is useful as it allows the user to list all KVs or ObjectStores returning a value that aligns with the result of status() for KV and ObjectStore as provided in those views. This is syntactic sugar over listing all streams that start with KV_ or OBJ_.

The behavior is documented in ADR-X.

Clients and Tools

Other Tasks

  • docs.nats.io updated @jnmoyne
  • Update ADR to Implemented
  • Update client features spreadsheet

Client authors please update with your progress. If you open issues in your own repositories as a result of this request, please link them to this one by pasting the issue URL in a comment or main issue description.

@aricart aricart added enhancement New feature or request client Client related work labels Sep 19, 2022
@ripienaar ripienaar removed their assignment Sep 20, 2022
@piotrpio piotrpio removed their assignment Sep 20, 2022
@scottf scottf removed their assignment Sep 30, 2022
@ripienaar
Copy link
Contributor

@piotrpio looking at the go PR its returning []string but here it says we should be returning equiv of Status() which you can do in one API call rather than return the names and then having to load each bucket to get at this.

@ripienaar
Copy link
Contributor

@piotrpio my bad, I didnt see you also added a way to get the status, sorry

@piotrpio
Copy link
Contributor

@ripienaar was just about to write that. The methods are added to match what we have for streams and consumers in go client, thus there are both available (even though for KV and object store getting names actually has to fetch streams, so it's more of a convenience than performance improvement).

@ripienaar
Copy link
Contributor

@piotrpio Yeah, sorry for the back and forth, but the KeyValueStores() returns KeyValue, to get status would then be another API call for every stream :(

The streams api call return full stream config and state, you can build up 1000s of kv status objects from a single API call.

@piotrpio
Copy link
Contributor

piotrpio commented Sep 30, 2022

@ripienaar I'll take a look. This was actually added prior to this issue, but not yet released, so we should be able to fix that without worrying about breaking changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Client related work enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

10 participants