Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaxAckPending vs pending limits #173

Open
2 of 11 tasks
scottf opened this issue Nov 21, 2022 · 0 comments
Open
2 of 11 tasks

MaxAckPending vs pending limits #173

scottf opened this issue Nov 21, 2022 · 0 comments
Assignees
Labels
client Client related work enhancement New feature or request

Comments

@scottf
Copy link
Collaborator

scottf commented Nov 21, 2022

Overview

Change clients to have the behavior described in the Go Client PR 920

When calling js.Subscribe() (or equivalent) and the library ended-up
creating the JS consumer, a MaxAckPending was set to a very high
value in some cases. We now let the server pick the default if the
value is not explicitly set by the user.
The NATS subscription pending limits are set in a way to ensure
that the subscription can store at least the max ack pending value.

Clients and Tools

Other Tasks

  • docs.nats.io updated @jnmoyne
  • Update ADR to Implemented
  • Update client features spreadsheet

Client authors please update with your progress. If you open issues in your own repositories as a result of this request, please link them to this one by pasting the issue URL in a comment or main issue description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Client related work enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

10 participants