adds the notion of a connection deadline to User #3580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used mainly by CustomClientAuthentication implementations to indicate that the user connection should be disconnected at some point in future - like when a certificate or token expires Signed-off-by: R.I.Pienaar <rip@devco.net>
|
@kozlovic draft PR to discuss what we spoke about, seemed easier than anticipated so I think I must be missing something, let me know your thoughts please? |
ripienaar
commented
Oct 27, 2022
| @@ -83,6 +84,14 @@ func (u *User) clone() *User { | |||
| clone := &User{} | |||
| *clone = *u | |||
| clone.Permissions = u.Permissions.clone() | |||
|
|
|||
| if len(u.AllowedConnectionTypes) > 0 { | |||
There was a problem hiding this comment.
dont know if this is needed, just noticed it might not be cloning this map so added it, not related to the PR really
kozlovic
approved these changes
Oct 27, 2022
| @@ -83,6 +84,14 @@ func (u *User) clone() *User { | |||
| clone := &User{} | |||
| *clone = *u | |||
| clone.Permissions = u.Permissions.clone() | |||
|
|
|||
| if len(u.AllowedConnectionTypes) > 0 { | |||
|
OK, will finish it tomorrow thanks |
|
Actually it does what I want right now, so I am happy to merge unless you have anythign else @kozlovic |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will be used mainly by CustomClientAuthentication implementations to indicate that the user connection should be disconnected at some point in future - like when a certificate or token expires
Signed-off-by: R.I.Pienaar rip@devco.net
/cc @nats-io/core