[ADDED] User Information requests at $SYS.REQ.USER.INFO #3671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Collison <derek@nats.io>
…account and permissions. Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
requested review from
wallyqs,
ripienaar,
Jarema,
ColinSullivan1 and
piotrpio
server/events.go
Outdated
| type UserInfo struct { | ||
| UserID string `json:"user"` | ||
| Account string `json:"account"` | ||
| Permissions *Permissions `json:"permissions,omitempty"` |
There was a problem hiding this comment.
Also include Time of Day restrictions and CIDR block restrictions? Expiration might be useful here too. wdyt?
There was a problem hiding this comment.
Yes we could add in limits and expiration. Will look into adding those.
There was a problem hiding this comment.
Let me add expiration, I think we hold on the others since that could open up a bunch of options on what is reported that blurs between user and accounts.
Will add expiration, that is a good add for sure.
This is only added if set by a user or account expiration claim. It is represented as a duration til expiration vs absolute time which would involve time zone and clock sync issues. Signed-off-by: Derek Collison <derek@nats.io>
ripienaar
approved these changes
Nov 28, 2022
|
Love this. No more peeking at connz to validate during testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow connected users to query information about bound account name and user permissions. This even works for users in the system account itself.
We do not return detailed account information here to allow for separate security/subject permissions for that and jetstream account information.
This should be added to NATS cli as a parallel call to account info when merged.
Note many of the changes are fixes to low level historical tests. When you add a base level system subscription that is imported by other accounts lots of test updates need to happen.
Signed-off-by: Derek Collison derek@nats.io
/cc @nats-io/core