New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CHANGE] [AC] flip aud and sub for consistency #3784
Conversation
Looks like the target branch should be |
correct and vendor stuff too - we should default to dev. |
// Build our request claims. | ||
claim := jwt.NewAuthorizationRequestClaims(AuthRequestSubject) | ||
// Build our request claims - jwt subject should be nkey | ||
jwtSub := acc.Name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also wondering if this really should acc.NKey
and name is a last resort.
Let's redo this to target dev.. |
it is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Flip out of draft mode and we can merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The auth request, the
sub
for the JWT isnats-authorization-request
, and theaud
is the nkey, typically our JWTs havesub
be an identity and theaud
is just a string describing where this jwt is applicable./cc @nats-io/core