Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth-Callout connect events #3799

Merged
merged 1 commit into from Jan 21, 2023
Merged

Auth-Callout connect events #3799

merged 1 commit into from Jan 21, 2023

Conversation

derekcollison
Copy link
Member

Make sure connection events during auth callouts are correct.

Fixed one extraneous account update for $G. We sent for the addition before switching but suppressed the change back to 0. We now suppress all for $G as was designed.

Signed-off-by: Derek Collison derek@nats.io

/cc @nats-io/core

@derekcollison derekcollison changed the base branch from main to dev January 21, 2023 01:36
@derekcollison derekcollison force-pushed the auth-callout-events branch 2 times, most recently from 1877cae to 95a1fb5 Compare January 21, 2023 02:16
Fixed one extraneous account update for $G. We sent for the addition before switching but suppressed the change back to 0.
We now suppress all for $G as was designed.

Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Contributor

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit e582f01 into dev Jan 21, 2023
@derekcollison derekcollison deleted the auth-callout-events branch January 21, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants