Allow editing RePublish on an existing stream
#3811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilalexander
force-pushed
the
neil/cfgrepublish
branch
from
abaf8bf
to
10d30a2
Compare
Jarema
reviewed
Jan 24, 2023
neilalexander
force-pushed
the
neil/cfgrepublish
branch
from
10d30a2
to
a586485
Compare
neilalexander
force-pushed
the
neil/cfgrepublish
branch
from
a586485
to
485a742
Compare
neilalexander
force-pushed
the
neil/cfgrepublish
branch
from
485a742
to
4f45df6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #3803 by allowing
RePublishto be edited on an existing stream.The
TestJetStreamClusterRePublishUpdateNotSupportedtest that was previously checking that it couldn't be updated has been renamed and rewritten to prove that modifyingRePublishon an existing stream works as intended.Signed-off-by: Neil Twigg neil@nats.io
/cc @nats-io/core