Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mappings breaking changes #3823

Merged
merged 1 commit into from Jan 27, 2023

Conversation

ripienaar
Copy link
Contributor

This undoes some breaking changes made in #3814

/cc @nats-io/core

Signed-off-by: R.I.Pienaar <rip@devco.net>
@ripienaar ripienaar changed the base branch from main to dev January 27, 2023 11:38
@ripienaar ripienaar marked this pull request as ready for review January 27, 2023 11:47
@ripienaar
Copy link
Contributor Author

These are in use by nats server mappings

@ripienaar
Copy link
Contributor Author

Not sure if I dont have the right permissions for Travis but I cant seem to rebuild just the failing job, if one of you have it please kick that job there are some flappers.

I've kicked a full rebuild twice and each time different fails so maybe more luck rebuilding just the one failing one

@neilalexander
Copy link
Member

Not sure if I dont have the right permissions for Travis but I cant seem to rebuild just the failing job, if one of you have it please kick that job there are some flappers.

I've kicked a full rebuild twice and each time different fails so maybe more luck rebuilding just the one failing one

Will kick the failing job.

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit b9f220e into nats-io:dev Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants