Fix stack overflow panic in reverse entry check when inbox ends with wildcard #3862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@derekcollison Would you like this on |
derekcollison
approved these changes
Feb 10, 2023
neilalexander
force-pushed
the
neil/accountstackoverflow
branch
from
1b1731e
to
ba0b1f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that the reverse entries also contain wildcards then this leads to infinite recursion. By breaking out the function to accept a parameter to tell us whether or not we have recursed, we can detect this condition and give up.
Signed-off-by: Neil Twigg neil@nats.io
/cc @nats-io/core