New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify authresponse #3864
Merged
Merged
Simplify authresponse #3864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caleblloyd
reviewed
Feb 12, 2023
caleblloyd
reviewed
Feb 12, 2023
caleblloyd
reviewed
Feb 14, 2023
aricart
force-pushed
the
simplify-authresponse
branch
2 times, most recently
from
February 18, 2023 18:24
6e88c04
to
ced92ae
Compare
aricart
force-pushed
the
simplify-authresponse
branch
from
February 20, 2023 13:46
ced92ae
to
769dd15
Compare
aricart
force-pushed
the
simplify-authresponse
branch
6 times, most recently
from
March 11, 2023 18:42
d3afc3b
to
faf38b7
Compare
Let me know when we think this one is ready for review. |
aricart
force-pushed
the
simplify-authresponse
branch
4 times, most recently
from
March 16, 2023 15:37
247f3b9
to
6c12ef5
Compare
removed server_key as name/id are already the right values
aricart
force-pushed
the
simplify-authresponse
branch
from
March 16, 2023 22:29
6c12ef5
to
52b023d
Compare
derekcollison
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks the auth callout to simply return an user JWT.
git pull --rebase origin main
)Changes proposed in this pull request:
The original auth callout response, is simpler:
{error: string, user_token: string}
. If encrypted the entire payload is encrypted.The callout service can now use account signing keys and scoped signing keys. The server will validate the signing keys used to match the target account, and in the case of the scoped signing key, will assign limits as recorded in the destination account. The one requirement is that the limits be default (zero) struct (otherwise the resulting JWT will be invalid once validation runs).
The audience field is now reserved for account placement on non-operator mode. In operator mode, the user JWT has all the proper attributions to determine the target account.
/cc @nats-io/core