Improvements to Filestore #3867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pire in each callback. This happens when under extreme load as shown in the skipped test. Signed-off-by: Derek Collison <derek@nats.io>
Will help in slow IO situations and lots of expire cache calls. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
neilalexander
approved these changes
Feb 14, 2023
|
Will merge, I have a followup coming that is an issue for monitoring probes and certain JetStream setups inside Kubernetes environments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only update on disk per subject information if we know we have an update.
Increase limit for internal blocking IO vs num cores. Will help in slow IO situations and lots of expire cache calls.
Improve expireMsgs minAge calculation for when lots of messages to expire in each callback.
/cc @nats-io/core