[FIXED] Do not delete consumers on restarts with non-fatal update errors. #3881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there was a spurious error on restart, or possibly on an update, we could delete a consumer which was the incorrect behavior. Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
bad-consumer-delete
branch
from
72ab858
to
01fa89a
Compare
neilalexander
approved these changes
Feb 18, 2023
Signed-off-by: Derek Collison <derek@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain scenarios during restarts we could propagate errors to the meta-layer and delete consumers.
Signed-off-by: Derek Collison derek@nats.io
/cc @nats-io/core