Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Do not warn if consumer replicas configured to 0 #3882

Merged
merged 1 commit into from Feb 18, 2023

Conversation

derekcollison
Copy link
Member

If a consumer had an older configuration with replicas of 0, we do not need to warn for an interest policy stream since the replicas will be inherited from the parent stream.

Signed-off-by: Derek Collison derek@nats.io

/cc @nats-io/core

Signed-off-by: Derek Collison <derek@nats.io>
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 9de8c08 into main Feb 18, 2023
@derekcollison derekcollison deleted the replica-warn branch February 18, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants