Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVED] Make sure preferred peer for stepdown is healthy. #3905

Merged
merged 1 commit into from Feb 23, 2023
Merged

[IMPROVED] Make sure preferred peer for stepdown is healthy. #3905

merged 1 commit into from Feb 23, 2023

Conversation

derekcollison
Copy link
Member

Signed-off-by: Derek Collison derek@nats.io

@derekcollison derekcollison requested a review from a team as a code owner February 23, 2023 20:17
@derekcollison derekcollison force-pushed the raft-stepdown-logic branch 3 times, most recently from 9d069fd to b70b706 Compare February 23, 2023 20:50
neilalexander
neilalexander approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

server/raft.go Outdated Show resolved Hide resolved
Jarema
Jarema approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@Jarema Jarema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison
Make sure preferred peer for stepdown is healthy.
45859e6 
Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison merged commit 79df099 into main Feb 23, 2023
@derekcollison derekcollison deleted the raft-stepdown-logic branch February 23, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

@neilalexander neilalexander neilalexander approved these changes

@Jarema Jarema Jarema approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@derekcollison @wallyqs @neilalexander @Jarema