Add original message timestamp to republished message headers #3933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test that failed seems unrelated to the code I changed and is passing locally. Any ideas on why it's failing and how I can fix it? |
|
I will kick it, that one is a flapper sometimes. |
|
This is a small change to include the original timestamp in the message headers when a message gets republished. How can I submit this for inclusion in the next release? |
|
We will review before 2.10. Working on getting 2.9.16 out the door atm. |
| @@ -4056,21 +4056,23 @@ func (mset *stream) processJetStreamMsg(subject, reply string, hdr, msg []byte, | |||
|
|
|||
| // Check for republish. | |||
| if republish { | |||
| tsStr := time.Unix(0, ts).UTC().Format(time.RFC3339Nano) | |||
|
Awesome!!! Thanks for taking a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds original message timestamp to republished message as "Nats-Time-Stamp" header
Resolves #NNNgit pull --rebase origin main)Resolves #
Changes proposed in this pull request: