Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Pull Consumer not sending request timeout #3942

Merged
merged 1 commit into from Mar 3, 2023

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Mar 3, 2023

Server did check for timeouts in processWaiting, but that needs to be also checked in nextWaiting in case of tight timings, as nextWaiting can remove Pull Request based on timeouts too.

Signed-off-by: Tomasz Pietrek tomasz@nats.io

Server did check for timeouts in `processWaiting`,
but that needs to be also checked in `nextWaiting` in case of
tight timings, as `nextWaiting` can remove Pull Request based on
timeouts too.

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@Jarema Jarema requested a review from a team as a code owner March 3, 2023 13:49
@Jarema Jarema marked this pull request as draft March 3, 2023 14:07
@Jarema Jarema marked this pull request as ready for review March 3, 2023 14:46
@Jarema Jarema merged commit c1af585 into main Mar 3, 2023
@Jarema Jarema deleted the jarema/fix-pull-consumer-timeout branch March 3, 2023 15:52
@Jarema Jarema mentioned this pull request Mar 3, 2023
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants