Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds a nightly build action and build nightly rc from main #3961

Merged
merged 1 commit into from Mar 14, 2023

Conversation

ripienaar
Copy link
Contributor

No description provided.

@ripienaar ripienaar requested a review from a team as a code owner March 14, 2023 17:10
@ripienaar
Copy link
Contributor Author

This creates a reuable action for building images, then use that in a new rc image, leaving the nightly one as is so it wont fail.

If this new build work I will upate the nightly tomorrow to use the same reusable action.

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bruth
Copy link
Member

bruth commented Mar 14, 2023

Given your last suggestion on Slack, I think nightly-main is more intuitive than rc.

Signed-off-by: R.I.Pienaar <rip@devco.net>
with:
go: "1.19"
branch: main
label: nightly-main
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated as discussed, will merge on green.

@ripienaar ripienaar merged commit 82e32d9 into nats-io:main Mar 14, 2023
1 check passed
@ripienaar ripienaar deleted the nightly_rc_docker branch March 14, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants