Fix bug in needAck #4008
Merged
Fix bug in needAck #4008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
force-pushed
the
jarema-fix-is-filtered
branch
from
ed6083d
to
10b790e
Compare
|
Make not a draft and we can merge it in. Do you have a test for it? |
|
Should we get a test in here too? |
|
Would be good. Working on it. Not trivial to test when found while checking code, not on failing test. EDIT, that is trivial :). Almost there. |
Jarema
force-pushed
the
jarema-fix-is-filtered
branch
from
10b790e
to
f0ff128
Compare
needAck has reverse logic for checking single subject-single filter scenario. Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Jarema
force-pushed
the
jarema-fix-is-filtered
branch
from
f0ff128
to
93c49c3
Compare
|
Tests added. |
derekcollison
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needAck has reverse logic for checking single subject-single filter
scenario.
Signed-off-by: Tomasz Pietrek tomasz@nats.io