[IMPROVED] Raft layer improvements #4020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g the monitor Signed-off-by: Derek Collison <derek@nats.io>
…e sure they are only processed if explicitly new Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
monitor-raft
branch
from
967499a
to
7d3ec51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes here.
Revert of a change regarding handling of leadership transfer entries that caused instability in some tests and a bad upgrade experience.
Make sure if we detect that a stream or a consumer is already running the monitoring routines that we do not stop the underlying raft group since it will be being used in the monitor routine and would stall that asset.
Signed-off-by: Derek Collison derek@nats.io