Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVED] Head of line improvements #4027

Merged
merged 2 commits into from Apr 6, 2023
Merged

[IMPROVED] Head of line improvements #4027

merged 2 commits into from Apr 6, 2023

Conversation

derekcollison
Copy link
Member

Signed-off-by: Derek Collison derek@nats.io

@derekcollison
RWMutex does not help here and could hurt
b6ebf0f 
Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison
Move check for out of resources which would want a read lock out of i…
e76b0b9 
…nline processing

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner April 6, 2023 03:40
wallyqs
wallyqs approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit a5326c9 into main Apr 6, 2023
2 checks passed
@derekcollison derekcollison deleted the hol-updates branch April 6, 2023 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@derekcollison @wallyqs