Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic in startingSequenceForSources #4035

Merged
merged 1 commit into from Apr 7, 2023
Merged

Fix panic in startingSequenceForSources #4035

merged 1 commit into from Apr 7, 2023

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Apr 7, 2023 •
edited

startingSequenceForSources had a potential panic at ssi.External.ApiPrefix.
This checks if `External is not nil before matching its ApiPrefix.

cc @jnmoyne

Signed-off-by: Tomasz Pietrek tomasz@nats.io

@Jarema
Fix panic in startingSequenceForSources
5715918 
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@Jarema Jarema requested a review from a team as a code owner April 7, 2023 15:35
derekcollison
derekcollison approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 51bb174 into dev Apr 7, 2023
2 checks passed
@derekcollison derekcollison deleted the fix-sourcing-nil-pointer branch April 7, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jarema @derekcollison