Fix consumer reply subject escaping #4040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyqs
reviewed
Apr 11, 2023
wallyqs
reviewed
Apr 11, 2023
Jarema
force-pushed
the
jarema-escape-formatting-symbol
branch
from
8ccb76a
to
00a2f91
Compare
|
What of the stream has a |
Jarema
force-pushed
the
jarema-escape-formatting-symbol
branch
from
00a2f91
to
add4553
Compare
If the Consumer had a name containing `%`, it could result in reply subject failing to format with `fmt.Sprintf`, as the `%` was not properly escaped with `%%`. Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Jarema
force-pushed
the
jarema-escape-formatting-symbol
branch
from
add4553
to
692f384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Consumer had a name containing
%, it could result in the reply subject failing to format withfmt.Sprintf, as the%was not properly escaped with%%.Resolves #4038
Signed-off-by: Tomasz Pietrek tomasz@nats.io