Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXES/IMPROVED] Raft and filestore logic #4045

Merged
merged 6 commits into from Apr 13, 2023
Merged

[FIXES/IMPROVED] Raft and filestore logic #4045

merged 6 commits into from Apr 13, 2023

Conversation

derekcollison
Copy link
Member

When failing to send a snapshot to a follower, in addition to stepping down reset our state.
For a filestore when expiring messages on recovery make sure that the first message is not a deleted message.
Fix a bad unlock of wrong type which could cause a crash during shutdown.
Add in raft specific test framework.

Signed-off-by: Derek Collison derek@nats.io

Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
…e sure to reset term

Signed-off-by: Derek Collison <derek@nats.io>
…large stream reports to avoid possible dupes

Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner April 13, 2023 14:44
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@derekcollison derekcollison merged commit 69b427b into main Apr 13, 2023
2 checks passed
@derekcollison derekcollison deleted the raft-tests branch April 13, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants