Fix stream sourcing & mirroring overlap errors #4052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding or updating sources/mirrors, server was checking if the stream with a given name exists to check for subject overlaps, among other things. However, if sourced/mirrored stream was `External`, checks should not be executed, as not only stream would never be found, but also, if `External` stream had the same name as the sourcing stream, the check would be wrongly performed against itself. Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Jarema
force-pushed
the
jarema-fix-stream-overlap-checks
branch
from
0de0888
to
a66c67b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding or updating sources/mirrors, server was checking if the stream with a given name exists to check for subject overlaps, among other things.
However, if sourced/mirrored stream was
External, checks should not be executed, as not only stream would never be found, but also, ifExternalstream had the same name as the sourcing stream, the check would be wrongly performed against itself.cc @jnmoyne
Signed-off-by: Tomasz Pietrek tomasz@nats.io