Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] Data race when setting up service import subscriptions. #4068

Merged
merged 1 commit into from Apr 17, 2023
Merged

[FIX] Data race when setting up service import subscriptions. #4068

merged 1 commit into from Apr 17, 2023

Conversation

derekcollison
Copy link
Member

Signed-off-by: Derek Collison derek@nats.io

@derekcollison
Fix for a data race when setting up service import subscriptions.
9a3e0b7 
Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner April 17, 2023 13:41
wallyqs
wallyqs approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

neilalexander
neilalexander approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit d8389ec into main Apr 17, 2023
2 checks passed
@derekcollison derekcollison deleted the service-imports-data-race branch April 17, 2023 13:57
@bruth bruth mentioned this pull request Apr 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wallyqs wallyqs wallyqs approved these changes

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@derekcollison @wallyqs @neilalexander