AVL trees and sequence sets for interior delete optimizations. #4070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge delete maps for streams. Signed-off-by: Derek Collison <derek@nats.io>
…enceSet. No other optimizations yet. Signed-off-by: Derek Collison <derek@nats.io>
* If we don't encode the `size`, it is lost during an encoding-decoding round-trip * If we don't check capacity, we might reallocate needlessly instead of just growing the slice Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
derekcollison
force-pushed
the
interior-deletes
branch
from
67bcb8f
to
333d684
Compare
neilalexander
added a commit
that referenced
this pull request
Apr 18, 2023
This also uses the AVL tree from #4070 in place of the map that currently tracks whether or not a sequence is present in the consumer redeliveries. Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Derek Collison derek@nats.io