Apply stream compression from file store config #4072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Twigg <neil@nats.io>
derekcollison
approved these changes
Apr 19, 2023
| var str string | ||
| switch alg { | ||
| case S2Compression: | ||
| str = "s2" |
There was a problem hiding this comment.
I suggest S2, I think that is how they refer to it.
There was a problem hiding this comment.
I stuck with the existing pattern from the JS schema here, which is that the values are all lower-case, although there is a separate String() function in the jsm.go PR that is for pretty-printing in the CLI ("S2 compression") so a CLI user never sees it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fills the missing link between the stream config and the actual compression state.
Related: nats-io/jsm.go#445, nats-io/natscli#762
Signed-off-by: Neil Twigg neil@nats.io