Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run a check for ack floor drift. #4086

Merged
merged 2 commits into from Apr 21, 2023
Merged

Run a check for ack floor drift. #4086

merged 2 commits into from Apr 21, 2023

Conversation

derekcollison
Copy link
Member

Also periodically check. If all normal will be very cheap.

Signed-off-by: Derek Collison derek@nats.io

…ack go routine is spun up.

Also periodically check. If all normal will be very cheap.

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner April 21, 2023 19:08
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

server/consumer.go Outdated Show resolved Hide resolved
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison merged commit f9f4bf5 into main Apr 21, 2023
2 checks passed
@derekcollison derekcollison deleted the consumer-ack-floor branch April 21, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants