Add op type to panics
#4108
Merged
Add op type to panics
#4108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
requested changes
Apr 27, 2023
server/jetstream_cluster.go
Outdated
| @@ -1728,7 +1728,7 @@ func (js *jetStream) applyMetaEntries(entries []*Entry, ru *recoveryUpdates) (bo | |||
| js.processUpdateStreamAssignment(sa) | |||
| } | |||
| default: | |||
| panic("JetStream Cluster Unknown meta entry op type") | |||
| panic(fmt.Sprintf("JetStream Cluster Unknown meta entry op type! %v", entryOp(buf[0]))) | |||
There was a problem hiding this comment.
Suggested change
| panic(fmt.Sprintf("JetStream Cluster Unknown meta entry op type! %v", entryOp(buf[0]))) | |
| panic(fmt.Sprintf("JetStream Cluster Unknown meta entry op type: %v!", entryOp(buf[0]))) |
There was a problem hiding this comment.
Should we log the more detailed stuff then panic with a simple unknown opcode?
This will not be a bug, fyi, this will be a fault, data corruption, etc. Hence the panic.
server/jetstream_cluster.go
Outdated
| @@ -2687,7 +2687,7 @@ func (js *jetStream) applyStreamEntries(mset *stream, ce *CommittedEntry, isReco | |||
| } | |||
| } | |||
| default: | |||
| panic("JetStream Cluster Unknown group entry op type!") | |||
| panic(fmt.Sprintf("JetStream Cluster Unknown group entry op type! %v", op)) | |||
There was a problem hiding this comment.
Suggested change
| panic(fmt.Sprintf("JetStream Cluster Unknown group entry op type! %v", op)) | |
| panic(fmt.Sprintf("JetStream Cluster Unknown group entry op type: %v!", op)) |
Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/oppanic
branch
from
8ca0890
to
e30ea34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
panicmessages on applying meta entries to include the faulty op type, so that we can better work out what's going on in these cases.Signed-off-by: Neil Twigg neil@nats.io