Record the stream and consumer info timestamps #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyqs
reviewed
May 5, 2023
This records the server time when info for streams and consumers are created so that tools such as the nats cli can calculate time deltas for last ack, last delivered and so forth in the context of the server clock. This will help aleviate problems with client devices experiencing clock jitter that can show up in user interfaces as negative seconds since last ack etc Signed-off-by: R.I.Pienaar <rip@devco.net>
ripienaar
force-pushed
the
consumer_stream_info_times
branch
from
8dd7474
to
fb1d86d
Compare
derekcollison
approved these changes
May 5, 2023
|
Line 2684 in 91607d8 |
|
To me, |
|
All monitor things using |
|
I am not hard set on either one, just brought it up to gather thoughts and opinions. I think since we are putting it in Stream and Consumer info should match the precedent set in JetStream to date, which sounds like what we already have in this PR. |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This records the server time when info for streams and consumers are created so that tools such as the nats cli can calculate time deltas for last ack, last delivered and so forth in the context of the server clock.
This will help aleviate problems with client devices experiencing clock jitter that can show up in user interfaces as negative seconds since last ack etc