Improve Consumer with multiple subjects #4188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jarema
force-pushed
the
jarema-work-on-multiple-filters
branch
3 times, most recently
from
6cc9b96
to
33c44c7
Compare
Jarema
commented
May 27, 2023
server/consumer.go
Outdated
| @@ -3247,7 +3252,7 @@ func (o *consumer) getNextMsg() (*jsPubMsg, uint64, error) { | |||
| store := o.mset.store | |||
|
|
|||
| // If no filters are specified, optimize to fetch just non-filtered messages. | |||
| if o.subjf == nil { | |||
| if o.subjf == nil || len(o.subjf) == 0 { | |||
There was a problem hiding this comment.
Just do len() since len(nil) is valid.
server/consumer.go
Outdated
| @@ -3313,31 +3315,36 @@ func (o *consumer) getNextMsg() (*jsPubMsg, uint64, error) { | |||
| // to avoid reflection. | |||
| if o.subjf != nil && len(o.subjf) > 1 { | |||
Jarema
force-pushed
the
jarema-work-on-multiple-filters
branch
from
ed52a36
to
1c4f664
Compare
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Jarema
force-pushed
the
jarema-work-on-multiple-filters
branch
from
1c4f664
to
261f39b
Compare
Jarema
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding more complex test scenarios, some issues in multiple-filters approach surfaced.
This PR adds those tests and addresses the issues.
Signed-off-by: Tomasz Pietrek tomasz@nats.io