Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Daisy chained leafnodes sometimes would not propagate interest #4207

Merged
merged 1 commit into from Jun 2, 2023

Conversation

derekcollison
Copy link
Member

@derekcollison derekcollison commented Jun 2, 2023

When we were optimizing for single cluster and large numbers of leafnodes we inadvertently broke a daisy chained scenario where a server was a spoke and a hub within a single hub server.

So interest on D would not propagate properly to server A as a publisher.

     B
   /    \
A       C -- D (SUB)
 |
PUB

…des we inadvertently broke a daisy chained scenarion where a server was a spoke and a hub with a single hub cluster.

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner June 2, 2023 23:26
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 22c97d6 into main Jun 2, 2023
2 checks passed
@derekcollison derekcollison deleted the daisy-leafnode-fix branch June 2, 2023 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants