Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic fixes #4214

Merged
merged 4 commits into from Jun 5, 2023
Merged

Panic fixes #4214

merged 4 commits into from Jun 5, 2023

Conversation

Zamony
Copy link
Contributor

@Zamony Zamony commented Jun 5, 2023 •
edited

  • Link to issue, e.g. Resolves #NNN
  • Documentation added (if applicable)
  • Tests added
  • Branch rebased on top of current main (git pull --rebase origin main)
  • Changes squashed to a single commit (described here)
  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the Apache 2 license

Resolves panics in the code.

Changes proposed in this pull request:

  • This PR fixes some of the panics in the code

artemseleznev and others added 2 commits June 2, 2023 13:19
@artemseleznev
different panic fixes
27a8b96 
Signed-off-by: Artem Seleznev <seleznyov.artyom@gmail.com>
@Zamony
Fix client panic on absent server field
f71c495
@Zamony Zamony requested a review from a team as a code owner June 5, 2023 12:48
derekcollison
derekcollison reviewed Jun 5, 2023
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look awesome! A few minor comments, but looks good.

server/route.go Outdated Show resolved Hide resolved
server/stream.go Outdated Show resolved Hide resolved
@derekcollison derekcollison self-requested a review June 5, 2023 19:50
derekcollison
derekcollison approved these changes Jun 5, 2023
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@derekcollison derekcollison merged commit df5df3c into nats-io:main Jun 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Zamony @derekcollison @artemseleznev