[FIXED] Check for invalid stream name in sources #4222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnmoyne
changed the title
…ociated new error if it isn't. Adresses #4141 Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Fix test using invalid stream names Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
|
Let me know which way you want to go on mirror error, then I will take a closer look and get this merged. |
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
|
I just did a final adjustment of those two new errors but I believe it's done now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4141Resolves #4141
Changes proposed in this pull request:
Adds a check that the stream name of a stream source is valid and associated new error if it isn't.