[CHANGED] LeafNode: remotes from same server binding to same hub account #4259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the server would reject a second remote leafnode connection from the same server if it was binding to the same account on the hub even if the remote was using different local accounts. Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
derekcollison
approved these changes
Jun 21, 2023
| defer ln.Shutdown() | ||
| l := &captureErrorLogger{errCh: make(chan string, 10)} | ||
| ln.SetLogger(l, false, false) | ||
| lopts, err := ProcessConfigFile(lconf) |
There was a problem hiding this comment.
Does this denote formatting spaces or something?
There was a problem hiding this comment.
This is because I transformed this test from a single to a t.Run() to cover cases where it should work (different local accounts) and should not (same local account). So the "old" body was shifted to the right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the server would reject a second remote leafnode connection from the same server if it was binding to the same account on the hub even if the remote was using different local accounts.
Signed-off-by: Ivan Kozlovic ivan@synadia.com