Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to disable jetstream ascii art #4261

Merged
merged 1 commit into from Jun 21, 2023

Conversation

renevo
Copy link
Contributor

@renevo renevo commented Jun 21, 2023

This option is not available in the config, and is only accessable to embeded servers where when using custom loggers can look pretty terrible

  • Branch rebased on top of current main (git pull --rebase origin main)
  • Changes squashed to a single commit (described here)
  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the Apache 2 license

Changes proposed in this pull request:

  • Add ability to disable the jetstream ascii art banner on embeded servers as when using custom logging skews the ascii art.
INFO[2023-06-20T21:00:54-07:00] Starting JetStream                           
INFO[2023-06-20T21:00:54-07:00] _ ___ _____ ___ _____ ___ ___   _   __  __   
INFO[2023-06-20T21:00:54-07:00] _ | | __|_   _/ __|_   _| _ \ __| /_\ |  \/  | 
INFO[2023-06-20T21:00:54-07:00] | || | _|  | | \__ \ | | |   / _| / _ \| |\/| | 
INFO[2023-06-20T21:00:54-07:00] \__/|___| |_| |___/ |_| |_|_\___/_/ \_\_|  |_| 
INFO[2023-06-20T21:00:54-07:00]                                              
INFO[2023-06-20T21:00:54-07:00] https://docs.nats.io/jetstream               
INFO[2023-06-20T21:00:54-07:00]                                          

@renevo renevo requested a review from a team as a code owner June 21, 2023 04:11
@bruth
Copy link
Member

bruth commented Jun 21, 2023

Thanks @renevo. LGTM, but will let the server team chime. Can you rebase it against the dev branch (targeting 2.10)?

This option is not available in the config, and is only accessable to embeded servers where when using custom loggers can look pretty terrible
@neilalexander neilalexander changed the base branch from main to dev June 21, 2023 15:04
Copy link
Contributor

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 7fcb920 into nats-io:dev Jun 21, 2023
1 check passed
@renevo renevo deleted the disable-banner branch June 21, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants