Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional check for TLS required in WebSocket INFO #4264

Merged
merged 1 commit into from Jun 21, 2023

Conversation

neilalexander
Copy link
Member

This should stop us reporting tls_required when we aren't reporting tls_available.

Signed-off-by: Neil Twigg neil@nats.io

Signed-off-by: Neil Twigg <neil@nats.io>
@neilalexander neilalexander marked this pull request as ready for review June 21, 2023 18:13
@neilalexander neilalexander requested a review from a team as a code owner June 21, 2023 18:13
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit a8fc352 into main Jun 21, 2023
2 checks passed
@derekcollison derekcollison deleted the neil/wsinfofix branch June 21, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants