Add support for re-encrypting streams with new key #4296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilalexander
force-pushed
the
neil/reencrypt
branch
2 times, most recently
from
04c6919
to
46321fd
Compare
server/filestore.go
Outdated
| mb.bek.XORKeyStream(buf, buf) | ||
| if err := os.WriteFile(mb.mfn, buf, defaultFilePerms); err != nil { | ||
| return err | ||
| // Generate new keys based on our |
There was a problem hiding this comment.
Funnily enough this unfinished comment was there before, I'll update it.
server/opts.go
Outdated
| @@ -2077,6 +2078,8 @@ func parseJetStream(v interface{}, opts *Options, errors *[]error, warnings *[]e | |||
| doEnable = mv.(bool) | |||
| case "key", "ek", "encryption_key": | |||
| opts.JetStreamKey = mv.(string) | |||
| case "old_key", "old_ek", "old_encryption_key": | |||
neilalexander
force-pushed
the
neil/reencrypt
branch
2 times, most recently
from
c34824f
to
5d58330
Compare
Signed-off-by: Neil Twigg <neil@nats.io>
…ers at the same time as changing keys Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/reencrypt
branch
from
5d58330
to
bc78e86
Compare
Jarema
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new
old_keyfield to the configuration file to allow transitioning from one encryption key to another.Signed-off-by: Neil Twigg neil@nats.io