Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate service imports when publishing advisories #4302

Merged
merged 3 commits into from Jul 12, 2023

Conversation

neilalexander
Copy link
Member

This should fix #4275 by allowing advisories to be copied into other accounts via service imports.

Signed-off-by: Neil Twigg neil@nats.io

…ccount

Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
@neilalexander neilalexander requested a review from a team as a code owner July 12, 2023 12:28
server/jetstream_events.go Outdated Show resolved Hide resolved
server/jetstream_events.go Outdated Show resolved Hide resolved
server/jetstream_events.go Outdated Show resolved Hide resolved
Signed-off-by: Neil Twigg <neil@nats.io>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Neil Twigg <neil@nats.io>
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 0c8552c into main Jul 12, 2023
2 checks passed
@derekcollison derekcollison deleted the neil/serviceimportadvisory branch July 12, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow messages published on $JS.EVENT.ADVISORY.API to be exported via a service
3 participants