Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] JetStream republished messages not being received by MQTT QoS0 subscribers #4303

Merged
merged 1 commit into from Jul 13, 2023

Conversation

derekcollison
Copy link
Member

Only discard messages from MQTT QoS0 from internal JetStream clients if really a QoS1 JetStream publish, not just a JetStream client.

Signed-off-by: Derek Collison derek@nats.io

Resolves #4291

…if really a QoS1 jetstream publish.

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner July 12, 2023 23:20
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 77189b0 into main Jul 13, 2023
2 checks passed
@derekcollison derekcollison deleted the issue-4291 branch July 13, 2023 14:26
@bruth
Copy link
Member

bruth commented Jul 13, 2023

Confirmed it worked in my example 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KV/stream republished messages do not propagate to MQTT subscriptions
3 participants