Don't require TLS for in-process connection

[neilalexander]

This should fix a bug where in-process connections expect TLS over the net.Pipe if TLS is configured.

Signed-off-by: Neil Twigg neil@nats.io

[neilalexander]

@caleblloyd Please test against this commit, should fix your issue.

[derekcollison]

LGTM

[caleblloyd]

@sethjback can you test the latest commit to make sure TLS is not required on in-process connections now, even if it is required on the NATS port?

[caleblloyd]

Getting a new error. Before this change, was seeing:

Error: tls: failed to verify certificate: x509: certificate signed by unknown authority

After this change, am seeing:

Error: tls: first record does not look like a TLS handshake

[derekcollison]

I will wait to merge until I hear from @neilalexander on the issue above.

[neilalexander]

Have pushed another commit that should resolve this without having to set AllowNonTLS in the config file, which would apply to all connections. Please give it a try.

[caleblloyd]

tls_required: true is still being sent in Server Info to the client, so the Client is attempting to upgrade to TLS... Think we need to detect/change that for the in-process client to send to tls_required: false, tls_available: true

[caleblloyd]

I think 4b064ff works, feel free to cherry-pick that as it is based on this branch already

[neilalexander]

OK, have added a unit test this time.

[caleblloyd]

Looks good!

[derekcollison]

LGTM