Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Track slow consumers per connection type #4330

Merged
merged 1 commit into from Aug 9, 2023
Merged

Track slow consumers per connection type #4330

merged 1 commit into from Aug 9, 2023

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Jul 20, 2023 •
edited

Adds a new slow_consumer_stats field to varz to get more details about the types of connections that are becoming slow consumers:

"slow_consumer_stats": {
    "clients": 0,
    "routes": 0,
    "gateways": 0,
    "leafs": 0
  }
  • Client Tests
  • Routes Tests
  • Gateway tests
  • Leafnode tests

@wallyqs wallyqs marked this pull request as ready for review July 21, 2023 05:55
@wallyqs wallyqs requested a review from a team as a code owner July 21, 2023 05:55
neilalexander
neilalexander approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting idea, LGTM

derekcollison
derekcollison requested changes Jul 21, 2023
View reviewed changes
server/server.go Outdated Show resolved Hide resolved
server/server.go Show resolved Hide resolved
@wallyqs wallyqs force-pushed the slow-consumers-per-connection branch 2 times, most recently from bbe963e to 956abd6 Compare July 24, 2023 21:05
@wallyqs wallyqs force-pushed the slow-consumers-per-connection branch 4 times, most recently from 01074df to cafca4f Compare August 8, 2023 22:26
@wallyqs
monitoring: track slow consumers per connection type
8b7dfe7 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs wallyqs force-pushed the slow-consumers-per-connection branch from cafca4f to 8b7dfe7 Compare August 9, 2023 12:57
@wallyqs wallyqs merged commit 65e8db7 into dev Aug 9, 2023
2 checks passed
@wallyqs wallyqs deleted the slow-consumers-per-connection branch August 9, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison requested changes

@neilalexander neilalexander neilalexander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wallyqs @derekcollison @neilalexander