Fixed local issuer determination for OCSP Staple, issue #3773 #4355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix also includes unit tests that verifies that both OCSP Staple and OCSP Peer features can be configured and used concurrently. |
wallyqs
reviewed
Aug 1, 2023
test/ocsp_test.go
Outdated
| serverCert := "configs/certs/ocsp_peer/mini-ca/server1/TestServer1_cert.pem" | ||
|
|
||
| var ( | ||
| // errExpectedNoStaple = fmt.Errorf("expected no staple") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves problems of issue #3773.
With this fix, NATS Server will locally determine it's own certificate's issuer from either the configured server certificate (bundle of leaf cert plus optional intermediate CA certs) or from the configured server CA trust store, as follows:
The operator may provide the server's certificate issuer in the second position of the server's certificate configuration (typically
cert_filebut may becert_storeon the Windows platform). If a candidate issuer is found here it is PKI validated as the actual issuer of the server's cert else a hard error.If not found in [1], NATS Server will seek to create at least one verified chain with its configured trust store (typically
ca_filebut could by the system trust store if not configured). It will derive the issuer from the first verified chain. If no verified chain can be formed it is a hard error.