Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: make parsing configurations without usable values invalid (backport) #4358

Merged
merged 1 commit into from Aug 2, 2023

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Aug 2, 2023

This makes configuration files that are empty, or read and processed by the parser but with no detected values now return an error.

Fixes #4343
Backport from dev branch (#4347)

@wallyqs wallyqs requested a review from a team as a code owner August 2, 2023 03:27
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This makes configuration files that are empty, or read and processed
by the parser but with no detected values now return an error.

Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs wallyqs merged commit 7c9a91f into main Aug 2, 2023
1 of 2 checks passed
@wallyqs wallyqs deleted the invalid-conf-main-fix branch August 2, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binary file accepted as valid configuration
2 participants