Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCSP backports and adds #4362

Merged
merged 3 commits into from Aug 3, 2023
Merged

OCSP backports and adds #4362

merged 3 commits into from Aug 3, 2023

Conversation

tbeets
Copy link
Contributor

@tbeets tbeets commented Aug 2, 2023

This PR backports the OCSP Peer feature option (as in 2.10 train) and includes two fixes for the existing OCSP Staple feature.

OCSP Staple:

  1. Fixed and clarified how NATS Server determines its own Issuer CA when obtaining and validating an OCSP Response for subsequent staple
  2. Eliminated problematic assumption that all node peers are issued by same CA when NATS Server validates ROUTE and GATEWAY peer nodes
  3. Added OCSP Response effectivity checks on ROUTE and GATEWAY peer-presented staple

Note for #3: Allowed host clock skew between node peers set at 30-seconds. If the OCSP Response contains an empty assertion for NextUpdate, NATS Server will default to 1-hour validity (after ThisUpdate). It is recommended that CA OCSP Responder should assert NextUpdate.

… no longer required to have same CA issuer. OCSP response effectivity now checked using default clock skew and default validity period if not asserted by responder.
@tbeets tbeets requested a review from a team as a code owner August 2, 2023 23:33
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 9de5e3e into main Aug 3, 2023
2 checks passed
@derekcollison derekcollison deleted the tgb/ocsp-backport branch August 3, 2023 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants