Match --signal PIDs with globular-style expression. #4370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevolk
force-pushed
the
jevolk/signālia
branch
2 times, most recently
from
70778dc
to
873be56
Compare
bruth
approved these changes
Aug 5, 2023
server/signal.go
Outdated
| if errStr != "" { | ||
| return errors.New(errStr) | ||
| } | ||
| return err |
There was a problem hiding this comment.
This is a nit, but it appears safe to return nil here since in all other cases above, an non-nil err value was returned appropriately. IMO, it helps with readability indicating that there is not fact not an error value that could propagate down this far.
|
Thanks for taking the time to review this so quickly. I have made the requested change. I have also added another test to ensure coverage for partial matches with a trailing glob. |
neilalexander
approved these changes
Aug 7, 2023
When multiple instances are running on the machine a PID argument suffixed with a '*' character will signal all matching PIDs. Example: `nats-server --signal reload=*` Signed-off-by: Jason Volk <jason@zemos.net>
bruth
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When multiple instances are running on the machine a PID argument suffixed with a '*' character will signal all matching PIDs.
Example:
nats-server --signal reload=*Resolves #NNNmaindev