Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stream config update of source transforms #4400

Merged
merged 2 commits into from Aug 16, 2023
Merged

Conversation

jnmoyne
Copy link
Contributor

@jnmoyne jnmoyne commented Aug 15, 2023

  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the Apache 2 license

Fixes potential out of range access during some stream source transform configuration updates and tiny clean up
Fixes stream sourcing message header parsing for multi-subject transform in sources

Clean up un-needed if statement as it's ok to call NewSubjectTransform with an empty destination (ie no transformation) it will return nil

Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
@jnmoyne jnmoyne requested a review from a team as a code owner August 15, 2023 23:37
Signed-off-by: Jean-Noël Moyne <jnmoyne@gmail.com>
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 7670cf5 into dev Aug 16, 2023
2 checks passed
@neilalexander neilalexander deleted the jnm/fix_15Aug23 branch August 16, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants