Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Durable pull consumers could get cleaned up incorrectly on leader change. #4412

Merged
merged 1 commit into from Aug 21, 2023

Conversation

derekcollison
Copy link
Member

Fix for a bug that would allow old leaders of pull based durables to delete a consumer from an inactivity threshold timer inadvertently.

Signed-off-by: Derek Collison derek@nats.io

…delete a consumer from an inactivity threshold.

Signed-off-by: Derek Collison <derek@nats.io>
@derekcollison derekcollison requested a review from a team as a code owner August 21, 2023 22:07
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 2fc3f45 into main Aug 21, 2023
2 checks passed
@derekcollison derekcollison deleted the consumer-inactive-bug branch August 21, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants