Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CORS support for the monitoring server #4423

Merged
merged 1 commit into from Aug 25, 2023
Merged

Conversation

mdawar
Copy link
Contributor

@mdawar mdawar commented Aug 23, 2023

  • Link to issue, e.g. Resolves #NNN
  • Documentation added (if applicable)
  • Tests added
  • Branch rebased on top of current main (git pull --rebase origin main)
  • Changes squashed to a single commit (described here)
  • Build is green in Travis CI
  • You have certified that the contribution is your original work and that you license the work to the project under the Apache 2 license

Resolves #4422

Changes proposed in this pull request:

  • Added Access-Control-Allow-Origin header to allow CORS requests for the monitoring server
  • Added a check in the tests for the header when the Content-Type is application/json

@mdawar mdawar requested a review from a team as a code owner August 23, 2023 13:51
Copy link
Member

@aricart aricart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - this will add the header and pacify the origin check

Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 5b18e80 into nats-io:main Aug 25, 2023
1 check passed
@mdawar mdawar deleted the cors branch August 26, 2023 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CORS requests are not supported by the monitoring server
3 participants