[FIXED] MQTT: Removed the use of tkDomain from retained msg subjects #4440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovic
approved these changes
Aug 28, 2023
There was a problem hiding this comment.
LGTM. But to be perfectly clear, leaving the domain here does not "break" anything (just makes the subjects longer). However this change (remove the domain) may break users that have used the "dev" branch against existing MQTT streams - and are using domains. I would assume that those users did not do that against production data, but that is something to keep in mind.
neilalexander
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Partially?) addresses #4349 (comment)
@kozlovic @neilalexander I did not remove the use of
domainTkin the session subject since it seems to have significance to it; removing it failedTestMQTTSessionsDifferentDomainsand I did not understand the specifics of the issue enough. Please let me know your thoughts.